HeaderFormatter: Use Strings.isNullOrEmpty Change-Id: I8185804e1ed50e6d182da20d8ef00bd8b0134a78 Signed-off-by: Edwin Kempin <ekempin@google.com>
diff --git a/src/main/java/com/googlesource/gerrit/plugins/reviewnotes/HeaderFormatter.java b/src/main/java/com/googlesource/gerrit/plugins/reviewnotes/HeaderFormatter.java index 3f7d406..17863a2 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/reviewnotes/HeaderFormatter.java +++ b/src/main/java/com/googlesource/gerrit/plugins/reviewnotes/HeaderFormatter.java
@@ -16,6 +16,7 @@ import static com.google.common.base.Preconditions.checkState; +import com.google.common.base.Strings; import com.google.gerrit.common.data.LabelType; import com.google.gerrit.common.data.LabelValue; import com.google.gerrit.reviewdb.client.Account; @@ -84,14 +85,14 @@ if (account.isPresent()) { String fullName = account.get().getFullName(); - if (fullName != null && !fullName.isEmpty()) { + if (!Strings.isNullOrEmpty(fullName)) { sb.append(fullName); needSpace = true; wroteData = true; } String preferredEmail = account.get().getPreferredEmail(); - if (preferredEmail != null && !preferredEmail.isEmpty()) { + if (!Strings.isNullOrEmpty(preferredEmail)) { if (needSpace) { sb.append(" "); }